Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(universal-xml-plugin): add checks to disable the plguin in webview #20179

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

sudharsan-selvaraj
Copy link
Contributor

@sudharsan-selvaraj sudharsan-selvaraj commented Jun 4, 2024

Proposed changes

Currently finding elements in webview is not working when the plugin is enabled. Added a check to make sure the plugin transforms the XML source only when the application context is set to NATIVE_APP.

Fixes #20060

Types of changes

What types of changes does your code introduce to Appium?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added @appium/universal-xml-plugin Bug a problem that needs fixing labels Jun 4, 2024
@github-actions github-actions bot added the chore refactoring, overhead, tests, etc. label Jun 4, 2024
@jlipps jlipps merged commit 7492c33 into appium:master Jun 6, 2024
9 checks passed
@jlipps
Copy link
Member

jlipps commented Jun 6, 2024

thanks @sudharsan-selvaraj !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@appium/universal-xml-plugin Bug a problem that needs fixing chore refactoring, overhead, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

universal-xml plugin issue with webview mode
3 participants