Fixes tests' incorrect use of .throw() assertion #6455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As pointed out in appium#6451, there are many test cases that do `should[.not].throw` instead of `should[.not].throw()`, which is incorrect and will never fail. This fixes those incorrect uses of the method as well as refactors/fixes the tests that turned out to be actually failing.
|
Can one of the admins verify this patch? |
| process.version = 'v0.9.12'; | ||
| checkNodeOk.should.throw; | ||
| checkNodeOk.should.throw(); | ||
| process.version = 'v0.1'; |
There was a problem hiding this comment.
Please let me know if you'd prefer to separate these new assertions into separate test cases.
|
I'm fine with just setting the debug flag in the test, but I also wouldn't mind if the As for the parts in a different PR: I would not repeat them. It would make merging more difficult in the long run. |
|
I'm good with this as-is. Thanks for taking this on! |
|
👍 thanks @usmonster. Guess we forgot to make sure our tests failed before they passed! |
9 tasks
|
Yup. The problem with post hoc tdd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This fixes some bad test cases. (Some minor refactoring was required for the tests that were failing.)
Types of changes
What types of changes does your code introduce to Appium?
Checklist
Further comments
A couple open questions/concerns about the changes I made:
p.debug = true;... Unless we can live with that, a better way might be to add an argument togetParser()that takes a boolean (or an options hash), which could allow us to pass along the debug flag in a cleaner way. What do you think?Reviewers: @imurchie, @jlipps, ...
As pointed out in #6451, there are many test cases that do
should[.not].throwinstead ofshould[.not].throw(), which isincorrect and will never fail.
This fixes those incorrect uses of the method as well as refactors/fixes
the tests that turned out to be actually failing.