-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documented "appWaitDuration" capability #6758
Conversation
Can one of the admins verify this patch? |
@@ -29,6 +29,7 @@ | |||
|`appPackage`| Java package of the Android app you want to run|`com.example.android.myApp`, `com.android.settings`| | |||
|`appWaitActivity`| Activity name for the Android activity you want to wait for|`SplashActivity`| | |||
|`appWaitPackage`| Java package of the Android app you want to wait for|`com.example.android.myApp`, `com.android.settings`| | |||
|`appWaitDuration`| Timeout in milliseconds used to wait for the appWaitActivity to launch (default `20000`), `30000`| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a |
instead of ,
before 3000
. Otherwise it gets in the wrong column in the table.
Thanks for this! One small tweak, then good to go! |
Can one of the admins verify this patch? |
Changed |
Looks good! Can you squash into a single commit, and we will get it in? Thanks! |
Done |
Excellent! Thanks for this! |
Proposed changes
This is required for #780
Following appium/appium-android-driver/pull/178 added documentation for added capability
Types of changes
What types of changes does your code introduce to Appium?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...
Reviewers: @imurchie, @jlipps, ...