-
-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement] Spring configuration, beans and aspects vs EventFiringWebdriver #242
Comments
Isn't it very strict to depend on Spring and AspectJ for proxifying objects for logging and other features? |
@GiannisPapadakis It would be good to have same AndroidDriver/IOSDriver or MobileElement with subclasses that also provide an ability to log events implicitly. Spring and AspectJ provide ability to create proxies of whole classes (not only interfaces) and implement that logging architecture in transparent and linear style. There are probably another suitable tools... |
It is ok with this solution of course. There are a lot of possibilities for Spring AOP to cover. You need of course to have a bean lifecycle. I could try some examples and review together if you want. |
@GiannisPapadakis |
Of course it would be great to have Spring features into java_client. But careful design should be approached in order to expose ApplicationContext and referenced beans correctly. |
Ok. I've got and this will be kept in mind. |
Now it is needed to add the listenable objet factory and cover it with tests
Also: - improvement of the WIKI chapter - update to org.springframework spring-context v4.3.1.RELEASE
It was found during the self-review.
The Selenium project has an interesting solution,
EventFiringWebDriver:
Everything is cool but I think there are disadvantages for Appium users:
The same is true for elements
What is supposed to be designed:
http://www.mkyong.com/spring3/spring-aop-aspectj-annotation-example/
The text was updated successfully, but these errors were encountered: