Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-design of the TimeOutDuration and WithTimeout. Use java.time.Duration instead of java.util.concurrent.TimeUnit #742

Closed
TikhomirovSergey opened this issue Sep 30, 2017 · 1 comment
Assignees
Labels

Comments

@TikhomirovSergey
Copy link
Contributor

TikhomirovSergey commented Sep 30, 2017

Description

  • mark old methods and parameters of the annotation @Deprecated

  • add get/set methods to the TimeOutDuration. These methods should get and set an instance of 'java.time.Duration'

  • WithTimeout should have a parameter of the java.time.temporal.ChronoUnit

Details

Java 8 is more powerful than 7. Also I think it is more correct way to use the native and general java.time package instead of more specifical java.util.concurrent in our case.

@TikhomirovSergey
Copy link
Contributor Author

Is going to be published soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant