Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Selenium >= 3.10.x #846

Closed
TikhomirovSergey opened this issue Mar 9, 2018 · 1 comment
Closed

Update to Selenium >= 3.10.x #846

TikhomirovSergey opened this issue Mar 9, 2018 · 1 comment
Assignees
@TikhomirovSergey
Labels
enhancement refactor

Comments

@TikhomirovSergey
Copy link
Contributor

TikhomirovSergey commented Mar 9, 2018 •
edited
Loading

Description

It needs to update the dependency on selenium to 3.10.0 or later version. But it has some major changes. So it needs for some efforts.

Details

It seems that Selenium team decided to use java.util.time.Duration for the explicit waiting instead of java.util.concurent.TimeUnit and long value. Current functionality should be refactored.

Related to: #742
@TikhomirovSergey TikhomirovSergey self-assigned this Mar 9, 2018
@joerg1985
Copy link

it looks like they are switching from ApacheHttpClient to OkHttpClient, see commit: SeleniumHQ/selenium@a731205

perhapse it makes sense for appium to switch to OkHttpClient too?

@TikhomirovSergey TikhomirovSergey mentioned this issue Apr 8, 2018
Merged
4 tasks
TikhomirovSergey added a commit that referenced this issue Apr 10, 2018
@TikhomirovSergey
Merge pull request #863 from TikhomirovSergey/master
470c27e 
 #846 and #742 FIX
SrinivasanTarget pushed a commit that referenced this issue Apr 18, 2018
@TikhomirovSergey @SrinivasanTarget
Addition to #846 and #855: (#869)
a542fee 
* Addition to #846 and #855:
- OkHttpClient instead of ApacheHttpClient
- fix of java.lang.IllegalArgumentException: Input byte array has incorrect ending byte at...

* Addition to #846 and #855:
- using of mime encoder/decoder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TikhomirovSergey TikhomirovSergey

Labels
enhancement refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TikhomirovSergey @joerg1985