feat: Add support for simctl features since Xcode SDK 11.4 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imurchie
reviewed
Feb 6, 2020
lib/simctl.js
Outdated
| log.errorAndThrow(`simctl error running '${command}': ${e.stderr.trim()}`); | ||
| } else { | ||
| log.errorAndThrow(e); | ||
| if (logErrors && e.stderr) { |
There was a problem hiding this comment.
This seems like a change in the semantics of logErrors. The docstring says "Set it to _false_ to throw execution errors immediately without logging any additional information", which does not any longer seem to be the case.
There was a problem hiding this comment.
makes sense
In general, I observe a lot of redundancy in this module. I'd rather make it into a class, so all these functions don't have to accept the same set of arguments (like udid and/or logErrors), but rather accept them in the constructor. What do you think @imurchie ?
There was a problem hiding this comment.
I agree. Especially since it seems like someone is actually adding things to simctl.
|
You beat me to it 😢 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.apple.com/documentation/xcode_release_notes/xcode_11_4_beta_release_notes?language=objc