pdftops filter produces invalid output

[michaelrsweet]

Version: 1.2.1
CUPS.org User: jpmg

pdftops/PSOutputDev.cxx:1161

writePSFmt("% Produced by xpdf/pdftops %s\n", xpdfVersion);

passes the string through a function in the printf family. Handling of the character sequence "% " is I believe specified to be undefined.

In practice, some operating systems map it to "% " (and thus no problem arises), but (for instance) when compiling on Solaris platforms, it is mapped to "", thus resulting in a bogus uncommented line near the top of the PS header.

I believe that

writePSFmt("%% Produced by xpdf/pdftops %s\n", xpdfVersion);

is both safe and correct on all platforms (I think it's ok to intersperse non-DSC comments within the DSC header)

[michaelrsweet]

CUPS.org User: mike

Fixed in Subversion repository.

FWIW, I opted to change the comment string to "%%Producer: xpdf/pdftops %s\n" to make it more parsable...