cupsaddsmb doesn't handle domain sockets

[michaelrsweet]

Version: 1.3-current
CUPS.org User: pipitas

Sine CUPS 1.2, users tryin to install the Windows/CUPS/Samba drivers very frequently encounter the same problem as described by this forum post, where a user did run "cupsaddsmb -v -U root -a":

http://www.cups.org/newsgroups.php?gcups.general+v:30889

The message displayed fortunately shows where the problem lays:

"[....] smbclient ///var/run/cups/cups.sock/print$ [....]"

It happens if there is support for unix domain socket connections (default in 1.2.x++) pre-compiled into the CUPS package.

However, smbclient (called by cupsaddsmb) does not work over unix domain sockets, it requires a TCP socket.

The man page (as well as the little help message displayed by "cupsaddsmb --foobar") should clearly hint at the fact that since 1.2 the correct usage of "-H" is required.

I think it should even be made mandatory in order to avoid this problem. (Don't ever default to any "localhost" assumption either....)

[michaelrsweet]

CUPS.org User: mike

Fixed in Subversion repository.

The real issue is that while we default the Samba server to the same host as the CUPS server, we weren't checking for a domain socket address. Mapping domain sockets to localhost preserves the prior behavior...