Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests do not build without multithreading #5154

Closed
rohieb opened this issue Oct 25, 2017 · 2 comments
Closed

tests do not build without multithreading #5154

rohieb opened this issue Oct 25, 2017 · 2 comments
Assignees
@michaelrsweet
Labels
priority-low
Milestone
CUPS 2.3.x

Comments

@rohieb
Copy link
Contributor

rohieb commented Oct 25, 2017

Commit 116c301 in v2.2.5 intruced an indirect dependency on cups/thread.o to test/ippserver.o, so it no longer builds with ./configure --disable-threads:

Linking ippserver...
ippserver.o: In function `ipp_print_job':
.../cups-2.2.5/test/ippserver.c:3881: undefined reference to `_cupsThreadDetach'
ippserver.o: In function `run_printer':
.../cups-2.2.5/test/ippserver.c:6812: undefined reference to `_cupsThreadDetach'
.../cups-2.2.5/test/ippserver.c:6830: undefined reference to `_cupsThreadDetach'
collect2: error: ld returned 1 exit status
Makefile:197: recipe for target 'ippserver' failed

Can the respective calls to _cupsThreadDetach() in ipptool etc. be hidden inside a proper #define? Otherwise, I guess everyone is building multithreaded anyways (I only had threading disabled accidentally for testing... :))
@michaelrsweet
Copy link
Collaborator

OK, we're missing a stub for that function... Will fix...

@michaelrsweet michaelrsweet self-assigned this Oct 25, 2017
@michaelrsweet michaelrsweet modified the milestones: CUPS 2.2.x Updates, CUPS 2.3.x Release Oct 25, 2017
@michaelrsweet
Copy link
Collaborator

[master 4d8e89a] Fix the ippserver sample code when threading is disabled or unavailable (Issue #5154)

michaelrsweet pushed a commit that referenced this issue Nov 1, 2017
Fix the ippserver sample code when threading is disabled or unavailab…
4d8e89a 
…le (Issue #5154)
@michaelrsweet michaelrsweet mentioned this issue Feb 26, 2018
Closed
michaelrsweet added a commit that referenced this issue Mar 7, 2018
@michaelrsweet
Backport CUPS 2.3.x changes to 2.2.x (Issue #5255)
1f71721 
- Fixed a compile issue when PAM is not available (Issue #5253)
- Documentation fixes (Issue #5252)
- Star Micronics printers need the "unidir" USB quirk rule (Issue #5251)
- The scheduler now supports using temporary print queues for older IPP/1.1 print queues like those shared by CUPS 1.3 and earlier (Issue #5241)
- The `cupsRasterWritePixels` function did not correctly swap bytes for some formats (Issue #5225)
- Added a USB quirk rule for Canon MP280 series printers (Issue #5221)
- The `ppdInstallableConflict` tested too many constraints (Issue #5213)
- More fixes for printing to old CUPS servers (Issue #5211)
- The `cupsCopyDest` function now correctly copies the `is_default` value (Issue #5208)
- The scheduler did not work with older versions of uClibc (Issue #5188)
- The scheduler now substitutes default values for invalid job attributes when running in "relaxed conformance" mode (Issue #5186)
- Fixed PAM module detection and added support for the common PAM definitions (Issue #5185)
- Fixed a journald support bug in the scheduler (Issue #5181)
- The cups-driverd program incorrectly stopped scanning PPDs as soon as a loop was seen (Issue #5170)
- Fixed group validation on OpenBSD (Issue #5166)
- Fixed the `ippserver` sample code when threading is disabled or unavailable (Issue #5154)
- The `cupsEnumDests` function did not include options from the lpoptions files (Issue #5144)
- The `SSLOptions` directive now supports `MinTLS` and `MaxTLS` options to control the minimum and maximum TLS versions that will be allowed, respectively (Issue #5119)
- The scheduler did not write out dirty configuration and state files if there were open client connections (Issue #5118)
- The `lpadmin` command now provides a better error message when an unsupported System V interface script is used (Issue #5111)
- The `lp` and `lpr` commands now provide better error messages when the default printer cannot be found (Issue #5096)
- No longer support backslash, question mark, or quotes in printer names (Issue #4966)
- The CUPS library now supports the latest HTTP Digest authentication specification including support for SHA-256 (Issue #4862)
- The `lpstat` command now reports when new jobs are being held (Issue #4761)
- The `lpoptions` command incorrectly saved default options (Issue #4717)
- The `ppdLocalizeIPPReason` function incorrectly returned a localized version of "none" (rdar://36566269)
- TLS connections now properly timeout (rdar://34938533)
- The IPP backend did not properly detect failed PDF prints (rdar://34055474)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelrsweet michaelrsweet

Labels
priority-low
Projects
None yet
Milestone
CUPS 2.3.x
Development

No branches or pull requests
2 participants
@rohieb @michaelrsweet