Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in include command #1121

Merged
merged 5 commits into from Feb 8, 2019

Conversation

mpilman
Copy link
Contributor

@mpilman mpilman commented Feb 6, 2019

This is the same PR as #1101 but against the release-6.0 branch

sfc-gh-mpilman and others added 2 commits February 6, 2019 09:38
This bug results in `include` to include all
machines that have a prefix of a given machine.

This is a weird bug that has to do with ASCII
ordering. Instead this command executes two
clears: one for the IP address and one for
all IP:PORT pairs
@ajbeamon
Copy link
Contributor

ajbeamon commented Feb 6, 2019

Would you mind also adding an entry to the release notes located at documentation/sphinx/source/release-notes.rst under a new 6.0.19 heading?

@mpilman
Copy link
Contributor Author

mpilman commented Feb 6, 2019

Sure, I added a short description

@AlvinMooreSr
Copy link
Contributor

test this please

1 similar comment
@AlvinMooreSr
Copy link
Contributor

test this please

documentation/sphinx/source/release-notes.rst Outdated Show resolved Hide resolved
documentation/sphinx/source/release-notes.rst Outdated Show resolved Hide resolved
@alexmiller-apple
Copy link
Contributor

@fdb-build, test this please

ajbeamon and others added 2 commits February 7, 2019 16:53
Co-Authored-By: mpilman <markus@pilman.ch>
Co-Authored-By: mpilman <markus@pilman.ch>
@ajbeamon ajbeamon merged commit a68dcdf into apple:release-6.0 Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants