Fix reverse range read performance bug #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d byte limit to the storage engine but would apply it to the results returned, causing a potentially significant amount of wasted reading.
|
I probably should have created this as a draft, but I'm still running some tests on it at the moment and it shouldn't be merged. |
…irection. This should not change any behavior.
…ry iterations in the forward case
…adRange from VectorRef<KeyValueRef> to RangeResultRef.
…iteration case in the forward direction when we don't exhaust our limits in the disk read. This also hopefully makes the code a bit clearer.
…rse range reads to match forward range reads
|
The tests are passing now, so this is ready for review. |
# Conflicts: # documentation/sphinx/source/release-notes.rst
|
@etschannen I've addressed the review comments on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverse range reads on the storage server would not pass the specified byte limit to the storage engine but would apply it to the results returned, causing a potentially significant amount of wasted reading.
CC @alecgrieser