Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tls fixes #396

Merged
merged 3 commits into from
May 21, 2018
Merged

Tls fixes #396

merged 3 commits into from
May 21, 2018

Conversation

richardalow
Copy link
Member

This code fixes the following issues:

  • correct client/server purpose validation
  • pass through key password
  • don't log verify failures unless all verification fails and only log at SevInfo

@satherton
Copy link
Contributor

Looks good to me.

@satherton satherton merged commit 2288e44 into apple:release-5.2 May 21, 2018
@richardalow richardalow deleted the tls-fixes branch May 21, 2018 23:53
sfc-gh-jfu pushed a commit to sfc-gh-jfu/foundationdb that referenced this pull request Jul 20, 2023
@sfc-gh-xwang
FDBCORE-4825 check serverList before update storage metadata (apple#396)
e842f8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@satherton satherton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardalow @satherton