Fix data distribution tracker memory bugs #4076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-tclinkenbeard
force-pushed
the
fix-dd-tracker-memory-issues
branch
from
bf54328
to
9014720
Compare
sfc-gh-tclinkenbeard
force-pushed
the
fix-dd-tracker-memory-issues
branch
from
9014720
to
ca8ea3b
Compare
| state DataDistributionTracker self(cx, distributorId, readyToStart, output, shardsAffectedByTeamFailure, | ||
| anyZeroHealthyTeams, *shards); | ||
| anyZeroHealthyTeams, *shards, *trackerCancelled); |
There was a problem hiding this comment.
What if we pass a copy of GetTracker to child actors here instead of a pointer to self? I think that would make it harder to accidentally dereference self after it's freed
| // Ideally this would be implemented with a lambda instead, but the actor compiler does not do | ||
| // type deduction. | ||
| class GetTracker { | ||
| bool const& trackerCancelled; |
There was a problem hiding this comment.
This is easier to reason about for me if the members are pointers /shrug
| @@ -658,8 +658,7 @@ ACTOR Future<Void> shardTracker(DataDistributionTracker::SafeAccessor self, KeyR | |||
| } | |||
| } catch (Error& e) { | |||
| // If e is broken_promise then self may have already been deleted | |||
There was a problem hiding this comment.
This comment is stale too now
sfc-gh-anoyes
approved these changes
Nov 17, 2020
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
Style
git clang-format).Performance
std::vectorvsVectorRef).SlowTasktraces.Testing
ASSERT,ASSERT_WE_THINK, andTESTmacros are added in appropriate places.