Fixed 'NoTraceFileGenerated' error in simulation tests when fdbserver process could not start #5179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement
When I run FoundationDb with joshua testing framework, all tests are failed with
NoTraceFileGenerated
error. I asked for a help in https://forums.foundationdb.org/t/simulation-testing-of-foundationdb/2654/6 but nobody could troubleshoot it.Finding
After some debugging I found that TestHarness.exe tried to start fdbserver but it couldn't start (in my case due an incompatible glibc version). In this case fdbserver did not write any trace files, so TestHarness.exe raised
NoTraceFileGenerated
. But such troubleshooting is not possible without debugging.Solution proposal
If fdbserver failed to start, then log the root cause instead of
NoTraceFileGenerated
.Testing result
After running correctness tests with changed TestHarness.exe, I receive a log with the real errors
Code-Reviewer Section
Please check each of the following things and check all boxes before accepting a PR.
If this PR is made against a release-branch, please also check the following:
release-branch
ormaster
if this is the youngest branch)