Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed and re-enable DataLossRecovery test #5868

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

liquid-helium
Copy link
Contributor

@liquid-helium liquid-helium commented Oct 28, 2021

Disabled HA in DataLossRecovery test since it was not designed for HA.

The test failed since remote team collection never started due to unrecovered remote DC.

Test: 10k runs of single DataLossRecovery 20211028-175427-heliu-78d3406f4804f546, without failures.

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or master if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for macOS Catalina 10.15

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: 46960be
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 46960be
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@sfc-gh-jslocum
Copy link
Collaborator

Seems fine to me.
Can you run a joshua ensemble of just this test to be sure there are no more issues before enabling it on master? Like 10k tests or something?

@liquid-helium
Copy link
Contributor Author

Seems fine to me.
Can you run a joshua ensemble of just this test to be sure there are no more issues before enabling it on master? Like 10k tests or something?

Done, 10K tests passed: 20211028-175427-heliu-78d3406f4804f546

@liquid-helium liquid-helium merged commit 6cf9f9b into apple:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants