Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport check exclude #7268

Merged
merged 3 commits into from
May 30, 2022
Merged

Backport check exclude #7268

merged 3 commits into from
May 30, 2022

Conversation

johscheuer
Copy link
Contributor

Backport of #7249

Code-Reviewer Section

The general guidelines can be found here.

Please check each of the following things and check all boxes before accepting a PR.

  • The PR has a description, explaining both the problem and the solution.
  • The description mentions which forms of testing were done and the testing seems reasonable.
  • Every function/class/actor that was touched is reasonably well documented.

For Release-Branches

If this PR is made against a release-branch, please also check the following:

  • This change/bugfix is a cherry-pick from the next younger branch (younger release-branch or main if this is the youngest branch)
  • There is a good reason why this PR needs to go into a release branch and this reason is documented (either in the description above or in a linked GitHub issue)

@johscheuer johscheuer requested a review from jzhou77 May 27, 2022 09:06
@johscheuer johscheuer marked this pull request as ready for review May 27, 2022 09:07
@fdb-windows-ci
Copy link
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr-cluster-tests
  • Commit ID: aa0e1a5
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@jzhou77 jzhou77 requested a review from halfprice May 27, 2022 16:12
@fdb-windows-ci
Copy link
Collaborator

Doxense CI Report for Windows 10

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr-cluster-tests
  • Commit ID: 2dc1ead
  • Result: FAILED
  • Error: Error while executing command: docker push --quiet ${REGISTRY}/foundationdb/foundationdb:${FDB_VERSION}-${COMMIT_SHA}-debug. Reason: exit status 125
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for macOS BigSur 11.5.2

  • CodeBuild project: foundationdb-pr-macos
  • Commit ID: 2dc1ead
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@foundationdb-ci
Copy link
Contributor

AWS CodeBuild CI Report for Linux CentOS 7

  • CodeBuild project: foundationdb-pr
  • Commit ID: 2dc1ead
  • Result: SUCCEEDED
  • Error: N/A
  • Build Logs (available for 30 days)

@johscheuer johscheuer merged commit 52e649b into apple:release-7.1 May 30, 2022
@johscheuer johscheuer deleted the backport-check-exclude branch May 30, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halfprice halfprice halfprice approved these changes

@jzhou77 jzhou77 jzhou77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@johscheuer @fdb-windows-ci @foundationdb-ci @halfprice @jzhou77