Skip to content

Commit

Permalink
Close ServerContext before Executor in AbstractNettyHttpServerTest (#…
Browse files Browse the repository at this point in the history
…1101)

Motivation:

Because the server's executor is closed before the server, all tests
from `AbstractNettyHttpServerTest` subclasses print
`TaskBasedSignalOffloader - Failed to execute task on the executor`
errors that pollute logs and make the build log unreadable.

Modifications:

- Close `ServerContext` before `Executor` in `AbstractNettyHttpServerTest`;

Result:

No `TaskBasedSignalOffloader` errors in test logs.
  • Loading branch information
idelpivnitskiy committed Jul 23, 2020
1 parent 5607b03 commit 1f44ea7
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ protected void service(final StreamingHttpService service) {

@After
public void stopServer() throws Exception {
newCompositeCloseable().appendAll(httpConnection, httpClient, clientExecutor, serverExecutor, serverContext)
newCompositeCloseable().appendAll(httpConnection, httpClient, clientExecutor, serverContext, serverExecutor)
.close();
}

Expand Down

0 comments on commit 1f44ea7

Please sign in to comment.