Ignore Http2SettingsAckFrame frame #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We currently don't handle the Http2SettingsAckFrame. We should ignore it but instead let it propagate to the end of the pipeline and get a warning debug message from Netty. Modifications: - Ignore the Http2SettingsAckFrame as we don't do anything with it. Result: Fixes apple#1122.
idelpivnitskiy
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We currently don't handle the Http2SettingsAckFrame. We should ignore it
but instead let it propagate to the end of the pipeline and get a
warning debug message from Netty.
Modifications:
Result:
Fixes #1122.