Disable auto ack for HTTP/2 PING frames by netty #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `KeepAliveManager#pingReceived` always acks PING frames. Netty's auto ack produces additional PING-ack frames that are not necessary and confusing. Modifications: - Use `Http2FrameCodecBuilder#autoAckPingFrame(false)` on client and server sides; Result: No duplicated PING frames written with ack=true.
idelpivnitskiy
commented
May 13, 2021
| @@ -48,6 +48,8 @@ public void init(final Channel channel) { | |||
| // The max concurrent streams is made available via a publisher and may be consumed asynchronously | |||
| // (e.g. when offloading is enabled), so we manually control the SETTINGS ACK frames. | |||
| .autoAckSettingsFrame(false) | |||
| // We ack PING frames in KeepAliveManager#pingReceived. | |||
| .autoAckPingFrame(false) | |||
There was a problem hiding this comment.
All PING frames are handled here and always ack'ed:
bondolo
approved these changes
May 13, 2021
hbelmiro
pushed a commit
to hbelmiro/servicetalk
that referenced
this pull request
May 23, 2021
Motivation: `KeepAliveManager#pingReceived` always acks PING frames. Netty's auto ack produces additional PING-ack frames that are not necessary and confusing. Modifications: - Use `Http2FrameCodecBuilder#autoAckPingFrame(false)` on client and server sides; Result: No duplicated PING frames written with ack=true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
KeepAliveManager#pingReceivedalways acks PING frames. Netty's autoack produces additional PING-ack frames that are not necessary and
confusing.
Modifications:
Http2FrameCodecBuilder#autoAckPingFrame(false)on client andserver sides;
Result:
No duplicated PING frames written with ack=true.