Add servicetalk-utils-internal module
#862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
heowc
force-pushed
the
add_utils_internal_module
branch
from
b9917f9
to
1e687e6
Compare
__Motivation__ We need to `servicetalk-utils-internal` module __Modifications__ Remove duplicate class(`MathUtil`) __Result__ Resolves apple#189
There was a problem hiding this comment.
@heowc Thank you for the contribution! Discussed approach lgtm. Few minor comments:
servicetalk-utils-internal/src/main/java/io/servicetalk/utils/internal/MathUtil.java
Outdated
Show resolved
Hide resolved
|
@servicetalk-bot test this please |
|
Thank for the review! |
|
@servicetalk-bot test this please |
idelpivnitskiy
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to
servicetalk-utils-internalmoduleModifications
Remove duplicate class(
MathUtil)Result
Resolves #189