Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LinuxMain.swift #367

Merged
merged 2 commits into from May 11, 2022
Merged

Conversation

keith
Copy link
Contributor

@keith keith commented Oct 27, 2021

Swift 5.5+ Swift Package Manager warns that --enable-test-discovery is
enabled by default. I assume for this project that should mean this
isn't needed anymore on main.

@keith
Copy link
Contributor Author

keith commented Oct 29, 2021

Related apple/swift-tools-support-core#251

@keith
Copy link
Contributor Author

keith commented Dec 6, 2021

@natecook1000 can you review?

@natecook1000
Copy link
Member

@swift-ci Please test

Swift 5.5+ Swift Package Manager warns that `--enable-test-discovery` is
enabled by default. I assume for this project that should mean this
isn't needed anymore on `main`.
@keith keith force-pushed the ks/remove-linuxmain.swift branch from 3e9fb86 to ea48472 Compare March 21, 2022 18:22
@keith
Copy link
Contributor Author

keith commented Mar 21, 2022

@swift-ci Please test

@keith
Copy link
Contributor Author

keith commented Mar 21, 2022

the main branch bumped the tools version to 5.5, so that change is no longer needed here

@keith
Copy link
Contributor Author

keith commented May 2, 2022

@natecook1000 could you review 🙏🏻

Copy link
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @keith!

@natecook1000
Copy link
Member

@swift-ci Please test

@keith
Copy link
Contributor Author

keith commented May 9, 2022

All green! (I don't have access to merge on this one)

@natecook1000
Copy link
Member

@swift-ci Please test

@natecook1000 natecook1000 merged commit 060d523 into apple:main May 11, 2022
@keith keith deleted the ks/remove-linuxmain.swift branch May 11, 2022 19:11
@keith
Copy link
Contributor Author

keith commented May 11, 2022

Thanks!

leuski pushed a commit to leuski/swift-argument-parser that referenced this pull request Jun 17, 2022
* 'main' of github.com:apple/swift-argument-parser: (114 commits)
  Fix `AsyncParseableCommand` hierarchy (apple#436)
  Add experimental manual page generation (apple#332)
  Improving edit distance string extension (apple#446)
  List valid options in error messages for enum array argument (apple#445)
  Remove LinuxMain.swift (apple#367)
  Hide hidden subcommands from completions (apple#443)
  Update changelog for 1.1.2 release (apple#441)
  Fix error message for @option array without values (apple#435)
  Fix Repeat's endless printing (apple#437)
  build: statically link ArgumentParserToolInfo always (apple#424)
  Update changelog for the 1.1.1 release (apple#428)
  build: complete the changes from apple#423 (apple#425)
  Remove platform requirement from Package.swift (apple#427)
  build: repair the build after apple#404 (apple#423)
  Fix broken links/incorrect variance calculation (apple#422)
  Update changelog for the 1.1.0 release (apple#421)
  Update documentation (apple#420)
  Make `@OptionGroup(visibility:)` a public API (apple#419)
  Support an `async` entry point for commands (apple#404)
  Fix a typo and template links (apple#418)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants