build: statically link ArgumentParserToolInfo always #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need some coordination with swift-installer-scripts; I'll write up a patch for that as well. Just wanted to run this past @natecook1000 to make sure that this seems reasonable. |
|
@swift-ci please test |
natecook1000
approved these changes
Mar 16, 2022
This was referenced Mar 20, 2022
Now that windows supports static linking as well (to a certain degree), alter the build of swift-argument-parser in CMake to use static linking for ArgumentParserToolInfo always irrespective of whether ArgumentParser is being built as a static library or a dynamic library. On Windows, in release mode, this saves ~32KiB. Additionally, because no tool directly links against this library, no binaries are further expanded by static linking, and we have one less file to distribute.
|
Seems like this will need to go in first with a tag to allow the remainder to go forward. |
|
@swift-ci please test |
|
@natecook1000 whenever you're ready, could you please merge this change and tag it? |
|
Oh, and for reference, the full joined thing was tested in apple/swift#41914. |
|
@natecook1000 gentle reminder on this |
|
Thanks, @compnerd — apologies for the delay! |
leuski
pushed a commit
to leuski/swift-argument-parser
that referenced
this pull request
Jun 17, 2022
* 'main' of github.com:apple/swift-argument-parser: (114 commits) Fix `AsyncParseableCommand` hierarchy (apple#436) Add experimental manual page generation (apple#332) Improving edit distance string extension (apple#446) List valid options in error messages for enum array argument (apple#445) Remove LinuxMain.swift (apple#367) Hide hidden subcommands from completions (apple#443) Update changelog for 1.1.2 release (apple#441) Fix error message for @option array without values (apple#435) Fix Repeat's endless printing (apple#437) build: statically link ArgumentParserToolInfo always (apple#424) Update changelog for the 1.1.1 release (apple#428) build: complete the changes from apple#423 (apple#425) Remove platform requirement from Package.swift (apple#427) build: repair the build after apple#404 (apple#423) Fix broken links/incorrect variance calculation (apple#422) Update changelog for the 1.1.0 release (apple#421) Update documentation (apple#420) Make `@OptionGroup(visibility:)` a public API (apple#419) Support an `async` entry point for commands (apple#404) Fix a typo and template links (apple#418) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that windows supports static linking as well (to a certain degree),
alter the build of swift-argument-parser in CMake to use static linking
for ArgumentParserToolInfo always irrespective of whether ArgumentParser
is being built as a static library or a dynamic library. On Windows, in
release mode, this saves ~32KiB. Additionally, because no tool directly
links against this library, no binaries are further expanded by static
linking, and we have one less file to distribute.
Replace this paragraph with a description of your changes and rationale. Provide links to an existing issue or external references/discussions, if appropriate.
Checklist