Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ASN1ObjectIdentifiers internal representation be the encoded form #36

Merged
merged 4 commits into from
Aug 17, 2023
Merged

Make ASN1ObjectIdentifiers internal representation be the encoded form #36

merged 4 commits into from
Aug 17, 2023

Conversation

dnadoba
Copy link
Member

@dnadoba dnadoba commented Aug 16, 2023 •
edited

This reduces allocations during parsing of certificates by ~50%.

@dnadoba dnadoba added the patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1) label Aug 16, 2023
@Lukasa Lukasa merged commit ce1faa4 into main Aug 17, 2023
6 checks passed
@Lukasa Lukasa deleted the dn-asn1-object-identifier branch August 17, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lukasa Lukasa Lukasa approved these changes

Assignees
No one assigned
Labels
patch-version-bump-only For PRs that when merged will only cause a bump of the patch version, ie. 1.0.x -> 1.0.(x+1)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dnadoba @Lukasa