Implement TinyArray #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnadoba
added
the
needs-no-version-bump
glbrntt
reviewed
Jun 16, 2023
glbrntt
approved these changes
Jun 19, 2023
Sources/X509/TinyArray.swift
Outdated
Comment on lines
115
to
113
| // we don't use lhs.elementsEqual(rhs) so we can hit the fast path from Array | ||
| // if both arrays share the same underlying storage: https://github.com/apple/swift/blob/b42019005988b2d13398025883e285a81d323efa/stdlib/public/core/Array.swift#L1775 |
Lukasa
reviewed
Jun 19, 2023
glbrntt
approved these changes
Jun 19, 2023
Lukasa
reviewed
Jun 19, 2023
.../tests_01_allocation_counters/test_01_resources/test_tiny_array_cow_append_contents_of.swift
Show resolved
Hide resolved
Lukasa
reviewed
Jun 19, 2023
...sts_01_allocation_counters/test_01_resources/test_tiny_array_non_allocating_operations.swift
Outdated
Show resolved
Hide resolved
and apply review feedback
dnadoba
commented
Jun 19, 2023
yim-lee
reviewed
Jun 20, 2023
Lukasa
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to improve allocations for a couple of collections that are only ever expected to store a single element. However, in rare cases they might store multiple elements so they still need to support that.