This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
Soft-deprecate -fapinotes-cache-path; use -fmodules-cache-path instead. #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Clang decided to change the default module cache path to include the current user's name, the API notes path didn't change. Rather than duplicate that logic, just put the API notes cache in with the module cache by default. We still support -fapinotes-cache-path in case anyone's using it, but from now on -fmodules-cache-path should be sufficient. (This is reasonable because API notes are currently linked to modules anyway.) https://bugs.swift.org/browse/SR-5806
jrose-apple
force-pushed
the
soft-deprecate-fapinotes-cache-path
branch
from
15b853f
to
3efc6c6
Compare
|
Requesting actual review because I plan to cherry-pick this to swift-4.1-branch (even though we're not under the formal review process yet). |
This was referenced Sep 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Clang decided to change the default module cache path to include the current user's name, the API notes path didn't change. Rather than duplicate that logic, just put the API notes cache in with the module cache by default. We still support -fapinotes-cache-path in case anyone's using it, but from now on -fmodules-cache-path should be sufficient. (This is reasonable because API notes are currently linked to modules anyway.)
SR-5806