This repository has been archived by the owner on Mar 28, 2020. It is now read-only.
On second thought, don't bother caching compiled API notes at all. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because API notes are always used with modules, and modules are always cached in PCM files, we don't really achieve any major wins by caching the API notes information separately. Just rebuild the PCM when the API notes change, like we do for headers. The next step is to not use the binary form at all. We don't really need it, for the same reason we don't need the cache. rdar://problem/31745420, also a better solution to https://bugs.swift.org/browse/SR-5806
DougGregor
approved these changes
Sep 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because API notes are always used with modules, and modules are always cached in PCM files, we don't really achieve any major wins by caching the API notes information separately. Just rebuild the PCM when the API notes change, like we do for headers.
The next step is to not use the binary form at all. We don't really need it, for the same reason we don't need the cache.
rdar://problem/31745420, also a better solution to SR-5806 than #119.