-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake based build #1720
CMake based build #1720
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like many of these changes but I’m really confused why they are in the CMake PR.
@millenomi - the underlying CF changes that can be done are in a separate PR (that should go in first). The Foundation side of the changes I expect will require the CF to be built as a framework (which is part of what I did in the CMake based build). Once the base CF changes are in, I will rebase this. The hack for plutil I haven't figured out why the type of doesn't work. After that, I am going to try to switch over the Foundation build to CMake :-) |
With the CMake build, will |
@spevans, sure, passing |
2845f46
to
c77380b
Compare
79adb29
to
bcb1430
Compare
The CMake based build uncovered that swift can sometimes get confused about the refernece to type in the interpolation. Workaround it by specifying the qualified name. Thanks to Lily Vulcano for the hint!
This set of change is less than ideal. However, this is the last piece to make the generated toolchain image currently the same with the old build system. With this in plae, we can finally switch over to CMake.
Please test with following PRs: @swift-ci please test Linux platform |
These set of changes are needed to build with the CMake system.