build: switch swift-corelibs-foundation to CMake #20032

compnerd · 2018-10-25T02:14:34Z

swift-corelibs-foundation has had a CMake based build system for a while
now. Switch the official builds over to it.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

compnerd · 2018-10-25T02:48:28Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720

@swift-ci please test

gottesmm · 2018-10-25T02:57:51Z

Nice! @compnerd does this mean that we don't need to use the weird build.py thing on Linux anymore?

compnerd · 2018-10-25T03:01:10Z

@gottesmm, yeap, that build.py can go away once this is merged!

gottesmm · 2018-10-25T03:10:11Z

Awesome! Another of the swift project's build systems bites the dust!

swift-ci · 2018-10-25T03:23:45Z

Build failed
Swift Test Linux Platform
Git Sha - 3eb408909e1b967d999539bd7fbee8b055903f83

compnerd · 2018-10-25T03:36:52Z

Ugh, FindICU was added in CMake 3.7. Time to replicate.

compnerd · 2018-10-25T05:29:07Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720

@swift-ci please test Linux platform

swift-ci · 2018-10-25T06:03:33Z

Build failed
Swift Test Linux Platform
Git Sha - 3eb408909e1b967d999539bd7fbee8b055903f83

gottesmm · 2018-10-25T16:41:45Z

@compnerd Took a quick look at the error. I think that somethings are getting imported wrong from the Framework. See:

01:03:31 /home/buildnode/jenkins/workspace/swift-PR-Linux/branch-master/swift-corelibs-foundation/Foundation/NSCalendar.swift:15:35: error: type 'CFCalendarUnit' (aka 'UInt') has no member 'day'
01:03:31 internal let kCFCalendarUnitDay = CFCalendarUnit.day.rawValue
01:03:31 ^~~~~~~~~~~~~~ ~~~

Clearly it is expected to be an enum I think.

compnerd · 2018-10-25T16:48:49Z

@gottesmm ... that sounds very likely. Yes, it is an enum (see CoreFoundation.framework/Headers/CFCalendar.h). That would explain why it works for me locally but fails on the build bot!

compnerd · 2018-10-25T19:52:24Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720

@swift-ci please test Linux platform

swift-ci · 2018-10-25T20:33:44Z

Build failed
Swift Test Linux Platform
Git Sha - 3eb408909e1b967d999539bd7fbee8b055903f83

compnerd · 2018-10-25T20:36:11Z

@gottesmm, @DougGregor - okay, this now reproduces the weird failure with plutil:

15:33:55 /home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-master/swift-corelibs-foundation/Tools/plutil/main.swift:205:80: error: cannot call value of non-function type 'DisplayType'
15:33:55                 fatalError("plists should have strings as keys but got a \(type(of: $0.0))")
15:33:55                                                                            ~~~~^
15:33:55 /home/buildnode/jenkins/workspace/swift-PR-Linux@2/branch-master/swift-corelibs-foundation/Tools/plutil/main.swift:305:42: error: cannot call value of non-function type 'DisplayType'
15:33:55         fatalError("unhandled type \(type(of: plist))")
15:33:55                                      ~~~~^

@millenomi - you may be interested in this as well.

compnerd · 2018-10-27T01:06:40Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720

@swift-ci please test Linux platform

compnerd · 2018-10-27T01:15:39Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720

@swift-ci please test

swift-ci · 2018-10-27T02:00:17Z

Build failed
Swift Test Linux Platform
Git Sha - 3eb408909e1b967d999539bd7fbee8b055903f83

compnerd · 2018-10-27T02:19:44Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720

@swift-ci please test

swift-ci · 2018-10-27T02:21:34Z

Build failed
Swift Test Linux Platform
Git Sha - 3eb408909e1b967d999539bd7fbee8b055903f83

swift-ci · 2018-10-27T02:55:05Z

Build failed
Swift Test OS X Platform
Git Sha - 3eb408909e1b967d999539bd7fbee8b055903f83

millenomi · 2018-10-27T16:14:59Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720

@swift-ci please test

swift-ci · 2018-10-27T16:49:51Z

Build failed
Swift Test Linux Platform
Git Sha - a5f6a4944c8ffd9ecd7741d2faf654f0635b7791

compnerd · 2018-10-27T19:38:19Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388

@swift-ci please test

swift-ci · 2018-10-27T20:08:35Z

Build failed
Swift Test Linux Platform
Git Sha - a5f6a4944c8ffd9ecd7741d2faf654f0635b7791

compnerd · 2018-10-27T20:56:08Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388

@swift-ci please test

swift-ci · 2018-10-27T20:56:32Z

Build failed
Swift Test OS X Platform
Git Sha - a5f6a4944c8ffd9ecd7741d2faf654f0635b7791

swift-ci · 2018-10-27T20:58:05Z

Build failed
Swift Test Linux Platform
Git Sha - a5f6a4944c8ffd9ecd7741d2faf654f0635b7791

compnerd · 2018-10-31T01:02:41Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388
apple/swift-package-manager#1833

@swift-ci please test Linux platform

gottesmm · 2018-10-31T01:15:45Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388
apple/swift-package-manager#1833

@swift-ci please test Linux platform

gottesmm · 2018-10-31T01:15:49Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388
apple/swift-package-manager#1833

@swift-ci please test Linux platform

gottesmm · 2018-10-31T01:17:38Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388
apple/swift-package-manager#1833

@swift-ci please test Linux platform

swift-ci · 2018-10-31T01:39:10Z

Build failed
Swift Test Linux Platform
Git Sha - 59b86e19de73664ad10567c9bc7ea810cc24f2bb

compnerd · 2018-10-31T04:19:58Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388
apple/swift-package-manager#1833

@swift-ci please test Linux platform

compnerd · 2018-10-31T05:08:32Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388
apple/swift-package-manager#1833

@swift-ci please test Linux platform

swift-ci · 2018-10-31T06:20:09Z

Build failed
Swift Test Linux Platform
Git Sha - 8458734dd0c386aa1aa6eea1e6768000e893687d

compnerd · 2018-10-31T06:23:07Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388
apple/swift-package-manager#1833

@swift-ci please test Linux platform

swift-ci · 2018-10-31T07:40:17Z

Build failed
Swift Test Linux Platform
Git Sha - 8458734dd0c386aa1aa6eea1e6768000e893687d

compnerd · 2018-10-31T15:26:42Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388
apple/swift-package-manager#1833

@swift-ci please test Linux platform

swift-ci · 2018-10-31T15:28:37Z

Build failed
Swift Test Linux Platform
Git Sha - 8458734dd0c386aa1aa6eea1e6768000e893687d

compnerd · 2018-10-31T16:44:45Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388
apple/swift-package-manager#1833
apple/swift-llvm#121

@swift-ci please test Linux platform

swift-ci · 2018-10-31T18:07:05Z

Build failed
Swift Test Linux Platform
Git Sha - d25e70397e6ae45e084906f5b3d7afb730e62788

compnerd · 2018-10-31T19:31:22Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388
apple/swift-package-manager#1833
apple/swift-llvm#121
apple/swift-corelibs-xctest#230

@swift-ci please test Linux platform

swift-ci · 2018-10-31T20:48:21Z

Build failed
Swift Test Linux Platform
Git Sha - d25e70397e6ae45e084906f5b3d7afb730e62788

swift-corelibs-foundation has had a CMake based build system for a while now. Switch the official builds over to it.

compnerd · 2018-10-31T21:01:51Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388
apple/swift-package-manager#1833
apple/swift-llvm#121
apple/swift-corelibs-xctest#230

@swift-ci please test

swift-ci · 2018-10-31T21:09:12Z

Build failed
Swift Test Linux Platform
Git Sha - d25e70397e6ae45e084906f5b3d7afb730e62788

compnerd · 2018-11-01T02:06:14Z

Please test with following PRs:
apple/swift-corelibs-foundation#1720
apple/swift-llbuild#388
apple/swift-package-manager#1833
apple/swift-llvm#121
apple/swift-corelibs-xctest#230

@swift-ci please test

spevans · 2018-11-01T09:28:37Z

@compnerd Will this still build and install the libFoundation.a static library?

compnerd · 2018-11-01T15:22:02Z

@spevans I have a patch to do that, but, this is a sufficiently complicated change that I want to split it into two changes.

spevans · 2018-11-02T16:22:45Z

@compnerd I think this may be causing some issues with xctest not being able to find CoreFoundation.h on macOS, see:

https://ci.swift.org/view/Pull%20Request/job/swift-corelibs-foundation-PR-macOS/139/consoleFull#12153878463122a513-f36a-4c87-8ed7-cbc36a1ec144

https://ci.swift.org/view/Pull%20Request/job/swift-corelibs-foundation-PR-macOS/138/console

/Users/buildnode/jenkins/workspace/swift-corelibs-foundation-PR-macOS/branch-master/Ninja-ReleaseAssert/xctest-macosx-x86_64/Release/usr/local/include/CoreFoundation/module.modulemap:2:21: error: umbrella header 'CoreFoundation.h' not found

compnerd force-pushed the cmake-foundation branch from 3eb4089 to a5f6a49 Compare October 27, 2018 02:11

compnerd mentioned this pull request Oct 27, 2018

build: update for the Foundation CMake based build layout apple/swift-llbuild#388

Merged

compnerd force-pushed the cmake-foundation branch from a5f6a49 to 1808c8c Compare October 27, 2018 20:56

compnerd force-pushed the cmake-foundation branch from 1808c8c to 0a8d8e5 Compare October 28, 2018 02:42

compnerd force-pushed the cmake-foundation branch from 1205f00 to 8458734 Compare October 31, 2018 01:02

compnerd force-pushed the cmake-foundation branch from 8458734 to d25e703 Compare October 31, 2018 15:26

build: switch swift-corelibs-foundation to CMake

58a4f0d

swift-corelibs-foundation has had a CMake based build system for a while now. Switch the official builds over to it.

compnerd force-pushed the cmake-foundation branch from d25e703 to 58a4f0d Compare October 31, 2018 20:58

gottesmm mentioned this pull request Nov 1, 2018

bootstrap: update for foundation layout apple/swift-package-manager#1833

Merged

compnerd mentioned this pull request Nov 1, 2018

CMake based build apple/swift-corelibs-foundation#1720

Merged

compnerd merged commit 679fc7d into apple:master Nov 2, 2018

compnerd deleted the cmake-foundation branch November 2, 2018 03:10

build: switch swift-corelibs-foundation to CMake #20032

build: switch swift-corelibs-foundation to CMake #20032

Conversation

compnerd commented Oct 25, 2018

compnerd commented Oct 25, 2018

gottesmm commented Oct 25, 2018

compnerd commented Oct 25, 2018

gottesmm commented Oct 25, 2018

swift-ci commented Oct 25, 2018

compnerd commented Oct 25, 2018

compnerd commented Oct 25, 2018

swift-ci commented Oct 25, 2018

gottesmm commented Oct 25, 2018

compnerd commented Oct 25, 2018

compnerd commented Oct 25, 2018

swift-ci commented Oct 25, 2018

compnerd commented Oct 25, 2018

compnerd commented Oct 27, 2018

compnerd commented Oct 27, 2018

swift-ci commented Oct 27, 2018

compnerd commented Oct 27, 2018

swift-ci commented Oct 27, 2018

swift-ci commented Oct 27, 2018

millenomi commented Oct 27, 2018

swift-ci commented Oct 27, 2018

compnerd commented Oct 27, 2018

swift-ci commented Oct 27, 2018

compnerd commented Oct 27, 2018

swift-ci commented Oct 27, 2018

swift-ci commented Oct 27, 2018

compnerd commented Oct 31, 2018

gottesmm commented Oct 31, 2018

gottesmm commented Oct 31, 2018

gottesmm commented Oct 31, 2018

swift-ci commented Oct 31, 2018

compnerd commented Oct 31, 2018

compnerd commented Oct 31, 2018

swift-ci commented Oct 31, 2018

compnerd commented Oct 31, 2018

swift-ci commented Oct 31, 2018

compnerd commented Oct 31, 2018

swift-ci commented Oct 31, 2018

compnerd commented Oct 31, 2018

swift-ci commented Oct 31, 2018

compnerd commented Oct 31, 2018

swift-ci commented Oct 31, 2018

compnerd commented Oct 31, 2018

swift-ci commented Oct 31, 2018

compnerd commented Nov 1, 2018

spevans commented Nov 1, 2018

compnerd commented Nov 1, 2018

spevans commented Nov 2, 2018