Parity: NSSortDescriptor & _CFSwiftArrayReplaceValues #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement the parts that can be implemented and annotate the rest with diagnostics. - Add a partially source-compatible version of init(keyPath:ascending:) that works with Comparable values. - A limited set of Cocoa model classes (the ones that have a compare(_:) method) now conforms to Comparable and can be used with the source-compatible initializer. - Implement the sort methods that take sort descriptors on the collection classes. - Add _SwiftBridgeable protocol conformance to a couple classes that had it missing. - Fix _CFSwiftArrayReplaceValues to actually work, and ensure CFArraySort() can detect that the array is actually mutable. - Ensure that NSOrderedSet invokes __SwiftValue’s fetching setup instead of returning internal storage.
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test |
|
I've filed a ticket related to this change: https://bugs.swift.org/browse/SR-10798. |
This was referenced May 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the parts that can be implemented and annotate the rest with diagnostics.
Add a partially source-compatible version of
init(keyPath:ascending:)that works with Comparable values.A limited set of Cocoa model classes (the ones that have a
compare(_:)method) now conforms to Comparable and can be used with the source-compatible initializer.Implement the sort methods that take sort descriptors on the collection classes.
Add
_SwiftBridgeableprotocol conformance to a couple classes that had it missing.Fix
_CFSwiftArrayReplaceValuesto actually work, and ensureCFArraySort()can detect that the array is actually mutable.Ensure that
NSOrderedSetinvokes__SwiftValue’s fetching setup instead of returning internal storage.