Fixup CryptoExtras RSA public key formats #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation
CryptoExtras RSA public keys support being exported in DER and PEM form.
These exports work great, but it turns out they are inconsistent between
the Darwin and non-Darwin implementations. Darwin platforms would export
the public keys in PKCS1 format, while non-Darwin was exporting them as
SPKI. This isn't great!
Modifications
- Make the two consistent. `.derRepresentation` should export SPKI
formatted public keys, because that's what it does for all the EC
keys.
- Add `.pkcs1DERRepresentation` and `.pkcs1PEMRepresentation` for those
users that require the PKCS1 formatted key.
Result
Key export types are now consistent on all platforms.
Lukasa
added
the
🔼 needs-minor-version-bump
FranzBusch
approved these changes
Mar 10, 2023
glbrntt
approved these changes
Mar 10, 2023
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CryptoExtras RSA public keys support being exported in DER and PEM form. These exports work great, but it turns out they are inconsistent between the Darwin and non-Darwin implementations. Darwin platforms would export the public keys in PKCS1 format, while non-Darwin was exporting them as SPKI. This isn't great!
Modifications
.derRepresentationshould export SPKI formatted public keys, because that's what it does for all the EC keys..pkcs1DERRepresentationand.pkcs1PEMRepresentationfor those users that require the PKCS1 formatted key.Result
Key export types are now consistent on all platforms.