Exclude AES from CMake #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SwiftPM doesn't need it and this would allow removal of CCryptoBoringSSL dependency on non-Darwin platforms, thus reducing SwiftPM size.
yim-lee
force-pushed
the
remove-aes-from-cmake
branch
from
b21fec3
to
be78e43
Compare
|
Need to add exclusions to |
Lukasa
approved these changes
Mar 16, 2023
Lukasa
added
the
needs-no-version-bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SwiftPM doesn't need it and this would allow removal of
CCryptoBoringSSLdependency on non-Darwin platforms, thus reducing SwiftPM size.Also removeCryptoKitErrors_boring.swiftin_CryptoExtrasbecause the same util already exists inCryptoand code in_CryptoExtrascan use that instead.