Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Wycheproof ecdh_secp256r1_test.json to v1 #160

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

Sajjon
Copy link
Contributor

@Sajjon Sajjon commented Apr 2, 2023

Update Wycheproof testvector ecdh_secp256r1_test v0 to ecdh_secp256r1_test v1.

Checklist

  • I've run tests to see all new and existing tests pass
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

If you've made changes to gyb files

  • I've run .script/generate_boilerplate_files_with_gyb and included updated generated files in a commit of this pull request

Motivation:

We ought to use as many and as up to date test vectors as possible. Wycheproofs v0 were created 4 years ago and were due some upgrade.

Modifications:

  • Replaced the v0 with the v1 version.
  • Changed fatalError in test code with a failable init.

Result:

Number of tests is now 612 instead of v0's test count of 340.

@Sajjon
Copy link
Contributor Author

Sajjon commented Apr 2, 2023

Cherry pick from #154

@Lukasa
Copy link
Collaborator

Lukasa commented Apr 3, 2023

@swift-server-bot test this please

@Lukasa Lukasa added the needs-no-version-bump For PRs that when merged do not need a bump in version number. label Apr 3, 2023
Copy link
Collaborator

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@Lukasa Lukasa merged commit 6be84be into apple:main Apr 3, 2023
@Sajjon Sajjon deleted the wycheproofv1/ecdh_secp256r1_test branch April 14, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-no-version-bump For PRs that when merged do not need a bump in version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants