Update Wycheproof multiple ECDSA test vectors to v1 #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Wycheproof ECDSA test vectors to v1. This PR updates one single unit test file:
ECDSASignatureTests
which contains tests forP256
,P383
andP521
with different Hash Function versions. Since all curves with HashFunctions are put in the same unit test file I had to update all vectors simultaneously.@Lukasa let me know if you prefer it I break out the each test vector file into seperate unit test files, and do one PR per test vector file.
Checklist
If you've made changes to
gyb
files.script/generate_boilerplate_files_with_gyb
and included updated generated files in a commit of this pull requestMotivation:
We ought to use as many and as up to date test vectors as possible. Wycheproofs v0 were created 4 years ago and were due some upgrade.
Modifications:
The following Wycheproof test vectors have been updated:
ecdsa_secp256r1_sha256_test.json
ecdsa_secp256r1_sha512_test.json
ecdsa_secp384r1_sha384_test.json
ecdsa_secp384r1_sha512_test.json
ecdsa_secp521r1_sha512_test.json
The following unit test file have been updated
ECDSASignatureTests.swift
, with a trivial JSON key change:key
->publicKey
.Result:
Many more tests are run.