Backport: Add API providing basic RSA pubkey encrypt and privkey decrypt (#125) #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#125) * Add basic RSA encrypt/decrypt API. * Add test vectors and tests for RSA encryption API * Fix build failures * Fix soundness issue * Remove support for RSA encryption using the unsafe PKCS1 v1.5 padding * Fix deprecation warning about the "pointer" version of Data.withUnsafeMutableBytes() by nudging the compiler to infer the "buffer" version. * Fix deprecation warning about String.init(bytesNoCopy:length:freeWhenDone:) by using String.init(unsafeInitializedCapacity:initializingWith:) instead. * Make _RSA.Encryption.[Public|Private]Key their own types * Remove _RSA.Encryption.RSA[Encrypted|Decrypted]Data and just use Data directly. Don't use intermediate Array in BoringSSL implementations. * Document the message size limits on RSA encrypt/decrypt operations * Mark `_RSA` visible to documentation so the new docs can actually be seen (underscored name is assumed private by default) * Fix generic type parameter shadowing warning (new warning in Swift 5.9) * Fix pre-5.8 build * Un-correct switch case indentation to make it wrong (cherry picked from commit 5ac5632)
Lukasa
added
the
🔼 needs-minor-version-bump
glbrntt
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #125 to a 2.6 branch.