Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to CryptoKit 2023 final API #199

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Conversation

Lukasa
Copy link
Collaborator

@Lukasa Lukasa commented Sep 13, 2023

Motivation

This patch brings us up-to-date with CryptoKit's final 2023 API form.

Modifications

Slight tweak to exporter secrets for HPKE to match final spec. New representation for SecureBytes when empty.

Result

We're ready for the future

Motivation

This patch brings us up-to-date with CryptoKit's final 2023 API form.

Modifications

Slight tweak to exporter secrets for HPKE to match final spec.
New representation for SecureBytes when empty.

Result

We're ready for the future
@Lukasa Lukasa added the ⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0 label Sep 13, 2023
Copy link
Contributor

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good modulo failing CI

@Lukasa
Copy link
Collaborator Author

Lukasa commented Sep 13, 2023

API breakage is expected.

@Lukasa Lukasa merged commit 629f0b6 into apple:main Sep 13, 2023
7 of 8 checks passed
@Lukasa Lukasa deleted the cb-update-to-2023-rc branch September 13, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠️ needs-major-version-bump For PRs that when merged cause a bump of the major version, ie. x.0.0 -> (x+1).0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants