Add support for pkcs1 oaep sha256 #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnro
force-pushed
the
add_support_for_PKCS1_OAEP_SHA256
branch
4 times, most recently
from
fb3b750
to
015421c
Compare
Lukasa
requested changes
Oct 30, 2023
Sources/_CryptoExtras/RSA/RSA.swift
Outdated
| case sha384 | ||
| case sha512 | ||
| case sha512_256 | ||
| case blake2b256 |
There was a problem hiding this comment.
This is excessive, let's just have only the digests we actually support.
| @@ -36,8 +36,13 @@ final class TestRSAEncryption: XCTestCase { | |||
|
|
|||
| let derPubKey = derPrivKey.publicKey | |||
|
|
|||
| guard group.sha == "SHA-1", group.mgfSha == "SHA-1" else { | |||
| // We currently only support SHA-1 OAEP, which is very legacy but oh well. | |||
| let padding: _RSA.Encryption.Padding | |||
There was a problem hiding this comment.
We should add a new set of test vectors: https://github.com/google/wycheproof/blob/master/testvectors/rsa_oaep_2048_sha256_mgf1sha256_test.json
Motivation Add RSA OAEP-sha256 support in addition to the increasingly aged SHA-1 implementation. Modifications * Add a `Digest` enum to `_RSA.Encryption.Padding` * Add a digest associated type to the `.pkcs1_oaep` padding enum case to allow us to distinguish different digest hash functions. * Add a `PKCS1_OAEP_SHA256` public static let to allow users to use the new hash function. * Enable SHA-256 RSA encryption tests Result * Support for RSA OAEP-sha256
rnro
force-pushed
the
add_support_for_PKCS1_OAEP_SHA256
branch
from
3ed779c
to
0974a60
Compare
Lukasa
approved these changes
Oct 31, 2023
Lukasa
added
the
🔼 needs-minor-version-bump
Lukasa
requested changes
Oct 31, 2023
rnro
force-pushed
the
add_support_for_PKCS1_OAEP_SHA256
branch
from
4f7fd18
to
3966fa4
Compare
dnadoba
approved these changes
Nov 1, 2023
Lukasa
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for pkcs1 oaep sha256
Motivation
Add RSA OAEP-sha256 support in addition to the increasingly aged SHA-1
implementation.
Modifications
Digestenum to_RSA.Encryption.Padding.pkcs1_oaeppadding enum caseto allow us to distinguish different digest hash functions.
PKCS1_OAEP_SHA256public static let to allow users to use thenew hash function.
Result
NOTE: This change sticks with the BoringSSL default behaviour and the case which uses the new SHA-256 digest hash function also uses SHA-256 as its mask generation function.