Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cxx interop build pipeline #212

Merged
merged 6 commits into from
Dec 21, 2023
Merged

Add cxx interop build pipeline #212

merged 6 commits into from
Dec 21, 2023

Conversation

gjcairo
Copy link
Contributor

@gjcairo gjcairo commented Dec 19, 2023

This PR adds a new target to docker-compose that builds this project with C++ interoperability enabled, with the goal of adding a new CI pipeline that performs this check.

Motivation:

To make sure that C++ interoperability can be used on projects that depend on swift-crypto.

Modifications:

  • Added a new target to docker-compose that builds this project with C++ interoperability enabled.
  • Will request a new CI pipeline that runs this new target.

Result:

We will ensure this projects builds properly with C++ interoperability enabled.

@gjcairo
Copy link
Contributor Author

gjcairo commented Dec 19, 2023

@yim-lee would you mind setting up a new pull request validation (cxx interop) pipeline that runs the new target?

@@ -35,6 +35,10 @@ services:
cmake:
<<: *common
command: /bin/bash -xcl "cmake -G Ninja -D CMAKE_BUILD_TYPE=Release -B out -S . && ninja -C out"

cxx-interop-build:
Copy link
Member

@yim-lee yim-lee Dec 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add cxx-interop-build to docker-compose.2204.59.yaml etc. to override image.

I updated docker-compose.2204.59.yaml in 6667d11

@yim-lee
Copy link
Member

yim-lee commented Dec 19, 2023

@swift-server-bot add to allowlist

@yim-lee
Copy link
Member

yim-lee commented Dec 19, 2023

@gjcairo I added new pipeline pull request validation (cxx interop) pipeline as requested. It uses Swift 5.9, similar to "api breakage" and "cmake" pipelines. We can set up separate "cxx interop" pipelines for Swift 5.9 and 5.10 if you want. Just let me know.

@yim-lee
Copy link
Member

yim-lee commented Dec 19, 2023

@swift-server-bot test this please

@gjcairo
Copy link
Contributor Author

gjcairo commented Dec 20, 2023

Thanks @yim-lee ! I had to make some changes to the step so hopefully it all still works :D
I think it would make sense to have a pipeline for 5.10 in this case, as I suppose things related to the interoperability may change between Swift versions and we want to make sure we are still green with newer versions. Would you mind setting up a second pipeline? I have updated the corresponding docker-compose file for 5.10 too.

@yim-lee
Copy link
Member

yim-lee commented Dec 20, 2023

CI updated. "5.9 cxx interop" and "5.10 cxx interop" replaced "cxx interop".

@swift-server-bot test this please

@Lukasa Lukasa merged commit 3e84977 into apple:main Dec 21, 2023
10 checks passed
@gjcairo gjcairo deleted the cxx-interop branch December 21, 2023 13:55
@Lukasa Lukasa added the needs-no-version-bump For PRs that when merged do not need a bump in version number. label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-no-version-bump For PRs that when merged do not need a bump in version number.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants