Prevent distributed singletons created during other's init from duping IDs #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
force-pushed
the
wip-dupe-id-singleton-during-init
branch
from
285538b
to
a9ed30f
Compare
…g IDs resolves apple#1131 rdar://112434926
ktoso
force-pushed
the
wip-dupe-id-singleton-during-init
branch
from
a9ed30f
to
c1ded19
Compare
ktoso
commented
Jul 18, 2023
| do { | ||
| return try SWIMActor.resolve(id: ._swim(on: self.asClusterNode!), using: system) | ||
| } catch { | ||
| fatalError("Failed to resolve \(ActorID._swim(on: self.asClusterNode!).detailedDescription): \(error), tree: \n\(system._treeString())") |
There was a problem hiding this comment.
Just improving error message, should not happen in real code but helps debug when we mess up assignID ;)
| where Act: DistributedActor | ||
| { | ||
| let props = _Props.forSpawn // task-local read for any properties this actor should have | ||
| let props = _Props.forSpawn.consume() // task-local read for any properties this actor should have |
yim-lee
approved these changes
Jul 18, 2023
Tests/DistributedClusterTests/Plugins/ClusterSingleton/ClusterSingletonPluginTests.swift
Outdated
Show resolved
Hide resolved
|
Just one of the jobs had a timeout #1133 failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We need to "consume" the sneaky way we sneak in the "use this ID" into
assignID. Without this we'd assign the same ID if someone were to create a singleton DURING the init() of another singleton.I need to work around a few aggressive assertions that are trying to prevent users doing bad stuff that we actually do want to do here, but this'll work ok.
Modifications:
We "consume" the "props for spawn" during assignID as it should be. This works because that's code generated as first thing in every distributed actor init.
Result:
resolves #1131
rdar://112434926
relates to rdar://112433423 which is about a language feature to enable control over this properly.