Introduce top level withSpan; reclaim Tracer and Instrument for protocols #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
requested review from
yim-lee,
slashmo,
fabianfett,
Lukasa,
tomerd and
weissi
ktoso
force-pushed
the
wip-reclaim-tracer-protocol-introduce-top-level-funcs
branch
2 times, most recently
from
470ab6a
to
d95bf10
Compare
ktoso
changed the title
stevapple
suggested changes
Mar 30, 2023
Lukasa
approved these changes
Mar 30, 2023
yim-lee
approved these changes
Mar 30, 2023
| /// - kind: The ``SpanKind`` of the new ``Span``. | ||
| /// - function: The function name in which the span was started | ||
| /// - fileID: The `fileID` where the span was started. | ||
| /// - line: The file line where the span was started. |
| /// - kind: The ``SpanKind`` of the new ``Span``. | ||
| /// - function: The function name in which the span was started | ||
| /// - fileID: The `fileID` where the span was started. | ||
| /// - line: The file line where the span was started. |
| /// - function: The function name in which the span was started | ||
| /// - fileID: The `fileID` where the span was started. | ||
| /// - line: The file line where the span was started. | ||
| /// - operation: The operation that this span should be measuring |
| /// - function: The function name in which the span was started | ||
| /// - fileID: The `fileID` where the span was started. | ||
| /// - line: The file line where the span was started. | ||
| /// - operation: The operation that this span should be measuring |
ktoso
commented
Mar 31, 2023
**Motivation:**
The TracerProtocol naming was annoyingly problematic and turns out we
can and should actually move the withSpan APIs as top level functions
which is typical Swift practice for such "global functionality".
This way we can `withSpan() {}` with less noise, and also gain back the
Tracer protocol name.
ktoso
force-pushed
the
wip-reclaim-tracer-protocol-introduce-top-level-funcs
branch
from
d859910
to
74b2beb
Compare
ktoso
force-pushed
the
wip-reclaim-tracer-protocol-introduce-top-level-funcs
branch
from
74b2beb
to
be47d00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The TracerProtocol naming was annoyingly problematic and turns out we can and should actually move the withSpan APIs as top level functions which is typical Swift practice for such "global functionality".
This way we can
withSpan() {}with less noise, and also gain back the Tracer protocol name.resolves #109