New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add banner that suggest to switch to preferred locale by user #554
Conversation
src/lang/locales/ja-JP.json
Outdated
@@ -1,4 +1,6 @@ | |||
{ | |||
"view-in": "View in 日本語", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To do: add correct translation strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I cannot test, because I dont have a dataset, but make sure the extra header does not intervene with the sticky components, like the navigator, both on mobile and desktop variants.
I remember I added some guards against such things, but in any case...
@swift-ci test |
…docc-render into r104924748/i18n-banner
Thanks Dobri! I've addressed your feedback. Give it another try :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will wait on design to approve too
@swift-ci test |
…docc-render into r104924748/i18n-banner
@swift-ci test |
@swift-ci test |
@swift-ci test |
) * [rdar://104924748] feat: start working on i18n banner * [rdar://104924748] feat: continue working on i18nbanner * [rdar://104924748] feat: store i18 banner in AppStore * [rdar://104924748] test: add and fix tests + fix headers * [rdar://104924748] refactor: styles * [rdar://104924748] fix: typo * [rdar://104924748] fix: alignment for i18n banner * [rdar://104924748] test: fix test * [rdar://104924748] fix: close icon size * [rdar://104924748] fix: banner code size * [rdar://104924748] fix: address feedback * [rdar://104924748] refactor: getLocaleParam function * [rdar://104924748] chore: update colors * [rdar://104924748] chore: move i18nBanner to App component * [rdar://104924748] refactor: replace i18nBanner with SuggestLang * [rdar://104924748] chore: move SuggestLang out of the header slot * [rdar://104924748] chore: use suggest-lang-height var * [rdar://104924748] chore: updates i18n strings * [rdar://104924748] test: fix tests
) * [rdar://104924748] feat: start working on i18n banner * [rdar://104924748] feat: continue working on i18nbanner * [rdar://104924748] feat: store i18 banner in AppStore * [rdar://104924748] test: add and fix tests + fix headers * [rdar://104924748] refactor: styles * [rdar://104924748] fix: typo * [rdar://104924748] fix: alignment for i18n banner * [rdar://104924748] test: fix test * [rdar://104924748] fix: close icon size * [rdar://104924748] fix: banner code size * [rdar://104924748] fix: address feedback * [rdar://104924748] refactor: getLocaleParam function * [rdar://104924748] chore: update colors * [rdar://104924748] chore: move i18nBanner to App component * [rdar://104924748] refactor: replace i18nBanner with SuggestLang * [rdar://104924748] chore: move SuggestLang out of the header slot * [rdar://104924748] chore: use suggest-lang-height var * [rdar://104924748] chore: updates i18n strings * [rdar://104924748] test: fix tests
…576) * [rdar://104924748] feat: start working on i18n banner * [rdar://104924748] feat: continue working on i18nbanner * [rdar://104924748] feat: store i18 banner in AppStore * [rdar://104924748] test: add and fix tests + fix headers * [rdar://104924748] refactor: styles * [rdar://104924748] fix: typo * [rdar://104924748] fix: alignment for i18n banner * [rdar://104924748] test: fix test * [rdar://104924748] fix: close icon size * [rdar://104924748] fix: banner code size * [rdar://104924748] fix: address feedback * [rdar://104924748] refactor: getLocaleParam function * [rdar://104924748] chore: update colors * [rdar://104924748] chore: move i18nBanner to App component * [rdar://104924748] refactor: replace i18nBanner with SuggestLang * [rdar://104924748] chore: move SuggestLang out of the header slot * [rdar://104924748] chore: use suggest-lang-height var * [rdar://104924748] chore: updates i18n strings * [rdar://104924748] test: fix tests
Bug/issue #104924748, if applicable:
Summary
Add banner that suggest to switch to preferred locale by user
Dependencies
NA
Testing
Steps:
theme-settings.json
file at public foldernpm run serve
Checklist
Make sure you check off the following items. If they cannot be completed, provide a reason.
npm test
, and it succeeded