Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Explicit Module Builds] Remove logic for Swift-client-specific Clang module dependency jobs #1332

Merged
merged 1 commit into from Apr 18, 2023
Merged

[Explicit Module Builds] Remove logic for Swift-client-specific Clang module dependency jobs #1332

merged 1 commit into from Apr 18, 2023

Commits on Apr 17, 2023

  1. [Explicit Module Builds] Remove logic for Swift-client-specific Clang… 

    … module dependency jobs

We have moved towards a build model where the output of the dependency scanner is the canonical collection of modules that must be built. The driver's logic to generate potentially multiple examples of a given Clang dependency, with different command sets, as required per Swift client module in the build graph, is no longer valid - even module output paths are no longer determined by the driver. Remaining logic that is removed in this PR may result in mistakenly producing duplicate jobs for the same Clang PCM build job.
    @artemcm
    artemcm committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    61937a8 View commit details
    Browse the repository at this point in the history