Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explain Dependency] Fix 'testTraceDependency' to account for Swift Overlay dependencies being separate from direct import dependencies. #1417

Merged
merged 1 commit into from Aug 17, 2023

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Aug 16, 2023

No description provided.

…verlay

Dependencies being separate from direct import dependencies.
@artemcm
Copy link
Contributor Author

artemcm commented Aug 16, 2023

@swift-ci test

Copy link
Contributor

@cachemeifyoucan cachemeifyoucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. How does this break?

@artemcm
Copy link
Contributor Author

artemcm commented Aug 17, 2023

LGTM. How does this break?

Just omits some edges from the output of -explain-module-dependency because overlays moved to a different category.

@artemcm artemcm merged commit 5378531 into apple:main Aug 17, 2023
3 checks passed
@artemcm artemcm deleted the FixTracingTestForOverlayDeps branch August 17, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants