[Dependency Scanning] Remove Swift Overlay dependencies from the set of direct dependencies #67928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
artemcm
force-pushed
the
DoNotCountOverlayDepsAsDirect
branch
from
ad28e39
to
521158e
Compare
|
@swift-ci test |
|
apple/swift-driver#1417 |
…of direct dependencies It is valuable for clients to be able to distinguish which dependencies of a Swift module originated from 'import' statements, and which ones are implicit dependency Swift overlays of imported Clang modules.
artemcm
force-pushed
the
DoNotCountOverlayDepsAsDirect
branch
from
521158e
to
4610a83
Compare
|
@swift-ci test |
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
Sep 26, 2023
…the set of direct dependencies Functionally reverts apple#67928. We must still support potentially older drivers which are not ready for this change due to: apple/swift-driver#1438
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
Sep 26, 2023
…the set of direct dependencies Functionally reverts apple#67928. We must still support potentially older drivers which are not ready for this change due to: apple/swift-driver#1438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is valuable for clients to be able to distinguish which dependencies of a Swift module originated from 'import' statements, and which ones are implicit dependency Swift overlays of imported Clang modules.
Breaking these dependencies out into a separate category will allow incremental builds to more-precisely determine if the project source import set has changed between builds, in order to aid with incremental builds.