[Explicit Module Builds] Fix topological sort of inter-module dependency graph to account for Swift overlay dependencies #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
cachemeifyoucan
approved these changes
Sep 7, 2023
| @@ -31,7 +31,7 @@ public enum ModuleDependencyId: Hashable { | |||
| } | |||
| } | |||
|
|
|||
| internal var moduleNameForDiagnostic: String { | |||
| var moduleNameForDiagnostic: String { | |||
There was a problem hiding this comment.
Is this used anywhere?
There was a problem hiding this comment.
We use this in incremental build explanation remarks. Though the change here was not intentional so I reverted it.
…ncy graph to account for Swift overlay dependencies
artemcm
force-pushed
the
FixTopoForExplicitOverlayDeps
branch
from
bc4e652
to
f4fc3b8
Compare
|
@swift-ci test |
|
@swift-ci test Windows platform |
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
Sep 26, 2023
…the set of direct dependencies Functionally reverts apple#67928. We must still support potentially older drivers which are not ready for this change due to: apple/swift-driver#1438
artemcm
added a commit
to artemcm/swift
that referenced
this pull request
Sep 26, 2023
…the set of direct dependencies Functionally reverts apple#67928. We must still support potentially older drivers which are not ready for this change due to: apple/swift-driver#1438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.