build: introduce a CMake based build for swift-format #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does require apple/swift-cmark#69 as well as apple/swift-markdown#141 |
|
CC: @ahoppen |
allevato
reviewed
Jan 9, 2024
bnbarham
reviewed
Jan 18, 2024
bnbarham
reviewed
Jan 23, 2024
There was a problem hiding this comment.
LGTM now other than the copyright headers still 😅. Same in the other linked PRs.
And would be good to run full toolchain builds in apple/swift#70814 first.
|
Now that the base change is in, yes, it is possible to do the toolchain test - which is not a "good" but really a "must" as we risk breaking the Windows installer build at the very least and we need to ensure that the packaged content is correct. |
This is in preparation to use SwiftFormat from SourceKit-LSP which is distributed as part of the toolchain. On Windows, we are now able to build swift-format against the shared Swift Syntax package, yielding an overall size reduction: SPM swift-format.exe: 75,683,840 b CMake swift-format.exe: 830,464 b SwiftFormat.dll: 7,818,240 b Net Savings: 67,035,136 b
bnbarham
approved these changes
Jan 26, 2024
allevato
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation to use SwiftFormat from SourceKit-LSP which is distributed as part of the toolchain.
On Windows, we are now able to build swift-format against the shared Swift Syntax package, yielding an overall size reduction:
SPM
swift-format.exe: 75,683,840 b
CMake
swift-format.exe: 830,464 b
SwiftFormat.dll: 7,818,240 b
Net Savings: 67,035,136 b