New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix recent build regression on Android #883
Conversation
#881 is probably fine for OpenBSD, since we're just changing headers at this point. (I really should do a build soon to confirm, but I'm a little behind on Swift stuff.) |
@swift-ci Please smoke test |
@swift-ci Please smoke test Windows platform |
The Windows CI got stuck? |
Wait a second, I screwed up my logic in the condition, will fix it. |
@al45tair, your suggestion in the comment above was right in the first place. I was trying to make it less convoluted, but my reformulation was not correct. |
@swift-ci Please smoke test |
@swift-ci Please smoke test Windows platform |
Windows CI failed at checkout, all others passed. |
@swift-ci Please smoke test windows platform |
Gah, should have written this as @al45tair, wdyt, worth another CI run to rewrite this? |
Up to you. I don't mind either way. Add another commit to get it how you want it and I'll trigger CI again for you. |
Bionic added execinfo.h last year, but only made the backtrace APIs available for Android API 33 or later.
Alright, rewrote it, one last CI run and this can go in. |
@swift-ci Please smoke test |
@swift-ci Please smoke test Windows platform |
@al45tair, this one and apple/swift#66745 are ready for merge. |
Bionic added execinfo.h last year, but only made the backtrace APIs available
for Android API 33 or later.
@3405691582, #881 also removed your OpenBSD check, but I see that OpenBSD recently added this header, mesonbuild/meson#11151, so the header check should suffice there?
@al45tair, you suggested this change, please review.
Here is the error message showing this failing on my Android CI, and the subsequent pull adding this change to my Android CI that fixed it, finagolfin/swift-android-sdk#112.