Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "openbsd: execinfo is not a compiler lib" #11151

Merged
merged 1 commit into from Dec 13, 2022

Conversation

brad0
Copy link
Contributor

@brad0 brad0 commented Dec 8, 2022

OpenBSD now has execinfo as compiler lib. DragonFly has all along.

This reverts commit 0241948.

@brad0 brad0 requested a review from jpakkane as a code owner December 8, 2022 23:45
@eli-schwartz eli-schwartz added the OS:*BSD Issues specific to one of the BSD Operating Systems label Dec 8, 2022
@eli-schwartz
Copy link
Member

@ajacoutot

@ajacoutot
Copy link
Contributor

@eli-schwartz yes this is correct nowadays.
Thanks.

@eli-schwartz
Copy link
Member

So the status has changed? The commit message should probably mention that.

@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #11151 (7d452aa) into master (b249470) will increase coverage by 2.71%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #11151      +/-   ##
==========================================
+ Coverage   66.07%   68.78%   +2.71%     
==========================================
  Files         414      414              
  Lines       90036    90030       -6     
  Branches    19290    21274    +1984     
==========================================
+ Hits        59488    61927    +2439     
+ Misses      26003    23441    -2562     
- Partials     4545     4662     +117     
Impacted Files Coverage Δ
mesonbuild/arglist.py 91.25% <100.00%> (+1.06%) ⬆️
mesonbuild/_typing.py 0.00% <0.00%> (ø)
interpreter/interpreter.py 84.34% <0.00%> (+0.05%) ⬆️
mesonbuild/dependencies/boost.py 82.25% <0.00%> (+0.20%) ⬆️
compilers/detect.py 46.83% <0.00%> (+0.23%) ⬆️
mesonbuild/interpreterbase/decorators.py 91.07% <0.00%> (+0.23%) ⬆️
mesonbuild/compilers/fortran.py 58.13% <0.00%> (+0.38%) ⬆️
dependencies/base.py 86.82% <0.00%> (+0.53%) ⬆️
compilers/compilers.py 82.60% <0.00%> (+0.59%) ⬆️
mesonbuild/interpreter/interpreterobjects.py 90.98% <0.00%> (+0.63%) ⬆️
... and 74 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jpakkane
Copy link
Member

Lint failure at least is relevant.

OpenBSD now has execinfo as compiler lib. DragonFly has all along.

This reverts commit 0241948.
@jpakkane
Copy link
Member

Test failure is unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS:*BSD Issues specific to one of the BSD Operating Systems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants