Merge pull request #1396 from jasonmolenda/r49036508-always-log-ptrac…

…e-pt-kill-failure
apple · Mar 20, 2019 · e4b0ffc · e4b0ffc
2 parents bda65cd + 5e89530
commit e4b0ffc
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/tools/debugserver/source/MacOSX/MachProcess.mm b/tools/debugserver/source/MacOSX/MachProcess.mm
@@ -1290,9 +1290,11 @@ static bool FBSAddEventDataToOptions(NSMutableDictionary *options,
   ::ptrace(PT_KILL, m_pid, 0, 0);
   DNBError err;
   err.SetErrorToErrno();
-  DNBLogThreadedIf(LOG_PROCESS, "MachProcess::Kill() DoSIGSTOP() ::ptrace "
-                                "(PT_KILL, pid=%u, 0, 0) => 0x%8.8x (%s)",
-                   m_pid, err.Status(), err.AsString());
+  if (DNBLogCheckLogBit(LOG_PROCESS) || err.Fail()) {
+    err.LogThreaded("MachProcess::Kill() DoSIGSTOP() ::ptrace "
+            "(PT_KILL, pid=%u, 0, 0) => 0x%8.8x (%s)",
+            m_pid, err.Status(), err.AsString());
+  }
   m_thread_actions = DNBThreadResumeActions(eStateRunning, 0);
   PrivateResume();