Use the MetricsTestKit in the MetricsTests rather than using a copy of the TestMetrics utilities #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzahrmalik
force-pushed
the
metric_test_refactor
branch
2 times, most recently
from
58477f1
to
e921a05
Compare
…f the TestMetrics utilities
hamzahrmalik
force-pushed
the
metric_test_refactor
branch
from
e921a05
to
9bc778a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the MetricsTestKit in the MetricsTests rather than using a copy of the TestMetrics utilities
Motivation:
Currently we have a copy of TestMetrics within the test target, which is entirely redundant
Modifications:
Make the test target rely on the existing MetricsTestKit target. Expand the functionality of MetricsTestKit to fill gaps needed for these existing tests
Result:
We lose the copy, and we exercise the public MetricsTestKit which gives us some confidence that it works